copy/merge in the FileManager and MultipartConfiguration changes from the maint. branch #36
Conversation
… 0.3.5.maintenance.
| // Clean up temporary files if instructed to do so. | ||
| // - Note that this is using the request scoped configuration. It is possible for the request handler to disable | ||
| // deletion of temporary files on a request basis. | ||
| var multiPartProcessor = request.getMultiPartStreamProcessor(); |
There was a problem hiding this comment.
Note, I think this is the correct way to do this.
In the pre 1.0 maint. branch where this code started, I didn't do this, and I only looked at the global config for deleting files. I could go patch that - but in practice, it may be ok for the time being. Ideally it won't be long before we can get all projects onto this 1.x line with virtual threads, etc.
| @@ -74,6 +74,7 @@ public Cookie(Cookie other) { | |||
| return; | |||
| } | |||
|
|
|||
| this.attributes.putAll(other.attributes); | |||
There was a problem hiding this comment.
This was just missing from the constructor. I could optionally go patch this in the maint. branch as well.
| throw new IllegalArgumentException("Boundary cannot be null."); | ||
| } | ||
|
|
||
| public MultipartStream(final InputStream input, final byte[] boundary, final MultipartFileManager multipartFileManager, |
There was a problem hiding this comment.
I'd like to collapse this into MultipartStreamProcessor since that is really what this is - but technically that would be a breaking change if we consider this part of the API.
|
Merging in from |
Related